Remove line separator for invisible elements #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
added a commit
that referenced
this pull request
May 28, 2021
Closed
bors
added a commit
to rust-lang/crates.io
that referenced
this pull request
Sep 13, 2021
Update `handlebars` crate to v4.1.3 see https://github.com/sunng87/handlebars-rust/blob/master/CHANGELOG.md ~It looks like none of the breaking changes in the v4 release are relevant to us.~ Update: I was wrong, sunng87/handlebars-rust#404 does affect us. I've added another commit which removes the now problematic handlebars whitespace control characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is an attempt to fix #258 with pest grammar.
The draw back of current solution is it removed whitespaces after
}}even if there is no line separator. Therefore this is going to be a break change. Case like{"a": [1,2,3,4], "b": "good"}Now renders as
1234goodinstead of1234 good.I'm trying to figure out if there is any solution to retain these whitespaces.
Update: the issue is fixed via 181565f