Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handlebars crate to v4.1.3 #3912

Merged
merged 2 commits into from Sep 13, 2021
Merged

Update handlebars crate to v4.1.3 #3912

merged 2 commits into from Sep 13, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 10, 2021

see https://github.com/sunng87/handlebars-rust/blob/master/CHANGELOG.md

It looks like none of the breaking changes in the v4 release are relevant to us.

Update: I was wrong, sunng87/handlebars-rust#404 does affect us. I've added another commit which removes the now problematic handlebars whitespace control characters.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 10, 2021
@locks
Copy link
Contributor

locks commented Sep 13, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 13, 2021

📌 Commit 030a8fb has been approved by locks

@bors
Copy link
Contributor

bors commented Sep 13, 2021

⌛ Testing commit 030a8fb with merge ed87d18...

@bors
Copy link
Contributor

bors commented Sep 13, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing ed87d18 to master...

@bors bors merged commit ed87d18 into rust-lang:master Sep 13, 2021
@Turbo87 Turbo87 deleted the handlebars branch September 14, 2021 20:31
bors added a commit that referenced this pull request Sep 17, 2021
tasks::dump_db: Add debug logging

This was helpful when working on #3912 :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants