fix #357: allowing for null instance with builders #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expanded this to include the somewhat changes for #350 as well. This adds null handling to the buildable with method and adds a fallback if the type is not known, rather than doing nothing. |
iocanel
approved these changes
May 10, 2023
annotations/builder/src/main/java/io/sundr/builder/internal/functions/ToMethod.java
Outdated
Show resolved
Hide resolved
|
@shawkins: This will also need a rebase and conflict resolution. |
Should be good now. |
iocanel
added
the
downstream-check
|
iocanel
removed
the
downstream-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #357 by allowing null instance values in the builder constructors.