Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(configs): Temporarily disable security audit in CI #446

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

connor-baer
Copy link
Member

Purpose

The security audit currently produces an error (IBM/audit-ci#103), causing CI to wrongly fail.

Approach and changes

  • Temporarily disable security audit in CI

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

The check currently produces an error, causing CI to wrongly fail.
@connor-baer connor-baer added 🛠️ tech Changes to the tech stack or infrastructure ready for review labels Jul 22, 2019
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #446 into canary will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           canary     #446   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files         163      163           
  Lines        2290     2290           
  Branches      389      389           
=======================================
  Hits         1706     1706           
  Misses        462      462           
  Partials      122      122

1 similar comment
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #446 into canary will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           canary     #446   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files         163      163           
  Lines        2290     2290           
  Branches      389      389           
=======================================
  Hits         1706     1706           
  Misses        462      462           
  Partials      122      122

@connor-baer connor-baer merged commit 065b5ec into canary Jul 23, 2019
@connor-baer connor-baer deleted the tech/disable-audit-ci branch July 23, 2019 09:07
@ilyanoskov
Copy link
Contributor

🎉 This PR is included in version 1.1.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ilyanoskov
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ tech Changes to the tech stack or infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants