Add PhoneNumberInput component #2500
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
* SX-2129 Edit phone number Circuit UI component * Add test for accessibility errors * Update documentation and add placeholder prop for the subscriber number * Update packages/circuit-ui/components/PhoneNumberInput/PhoneNumberInput.tsx Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com> * Update packages/circuit-ui/components/PhoneNumberInput/PhoneNumberInputService.spec.ts Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com> * Update packages/circuit-ui/components/PhoneNumberInput/PhoneNumberInput.mdx Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com> * Update packages/circuit-ui/components/PhoneNumberInput/PhoneNumberInput.mdx Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com> * Add fallback logic for Intl.DisplayNames * Update stories to have only one validation story * Update docs and readonly props * Update code country to be of type input when read only and reset validation hint as additional field * Update country code input element to not trigger countryCode onChange property * Remove legacy useEffect * Trigger deployment --------- Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com> Co-authored-by: Connor Bär <github@connorbaer.com>
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2500 +/- ##
==========================================
+ Coverage 88.16% 88.29% +0.12%
==========================================
Files 204 206 +2
Lines 22320 22752 +432
Branches 1490 1518 +28
==========================================
+ Hits 19678 20088 +410
- Misses 2590 2612 +22
Partials 52 52
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-654.
Purpose
The new phone number input component allow us to collect accurate, consistently formatted phone numbers including the country code and minimize the amount of friction for users.
Requirements
Approach and changes
Definition of done