Fix compatibility of the dialog-polyfill with isomorphic environments #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f00d326 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
connor-baer
force-pushed
the
fix/dialog-polyfill-universal
branch
from
11ee5da
to
f00d326
Compare
connor-baer
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2497 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 204 204
Lines 22320 22320
Branches 1490 1490
=======================================
Hits 19678 19678
Misses 2590 2590
Partials 52 52
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to GoogleChrome/dialog-polyfill#230.
Purpose
The
dialog-polyfillpackage unsafely accesses thewindowobject, causing errors in server environments.Approach and changes
dialog-polyfillpackage, specifically GoogleChrome/dialog-polyfill#231, which adds support for safely importing the polyfill in isomorphic environments.Definition of done