-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the Input element type #2306
base: next
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2306 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 251 251
Lines 19923 19930 +7
Branches 1226 1226
=======================================
+ Hits 19358 19365 +7
Misses 551 551
Partials 14 14
|
This comment was marked as outdated.
This comment was marked as outdated.
This change has been postponed until the next major release. |
Purpose
Describe what you are trying to accomplish
HTMLInputElement
andHTMLTextAreaElement
doesn't reflect the intended and real-world usage
hide complexity inside the design system and simplify the public API
Approach and changes
InputElement
interface. Use theHTMLInputElement
orHTMLTextAreaElement
interfaces instead.HTMLInputElement
and the TextArea's element type toHTMLTextAreaElement
. This affectsref
s and event handlers.Definition of done