Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the global style reset #2237

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

connor-baer
Copy link
Member

Purpose

CSS resets are used to reduce browser inconsistencies in things like default line heights, margins and font sizes of headings, and so on. All browsers have presentation defaults, but no browsers have the same defaults.

Circuit UI’s global base styles are pretty opinionated and can clash with other frameworks or styles used on a page. This pull request aims to reduce or remove the global styles to prevent these kinds of conflicts. It will be an opt-in change.

Approach and changes

Describe how you solved the problem

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 7:40pm

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

⚠️ No Changeset found

Latest commit: ae3e5af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2237 (ae3e5af) into main (c02b94a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2237   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files         251      251           
  Lines       19750    19750           
  Branches     1198     1198           
=======================================
  Hits        19149    19149           
  Misses        581      581           
  Partials       20       20           

Copy link
Contributor

github-actions bot commented Nov 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the pull request is still relevant to prevent it from being closed.

@github-actions github-actions bot added the stale label Nov 6, 2023
@connor-baer
Copy link
Member Author

I'm back from my sabbatical and will continue working on this PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant