Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions prop to NotificationInline #2062

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a5e
Copy link
Contributor

@a5e a5e commented Apr 24, 2023

Purpose

Adds the possibility to have multiple actions in a NotificationInline component.

Internal link to the design discussion in Figma

Approach and changes

  • Add an actions prop (actions and action are mutually exclusive)

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@a5e a5e requested a review from a team as a code owner April 24, 2023 15:40
@a5e a5e requested review from connor-baer and removed request for a team April 24, 2023 15:40
@sumup-clark
Copy link

sumup-clark bot commented Apr 24, 2023

Hey @a5e,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2023

⚠️ No Changeset found

Latest commit: 0c4c1ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Apr 24, 2023 3:40pm

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #2062 (0c4c1ce) into main (a62c441) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2062   +/-   ##
=======================================
  Coverage   92.16%   92.17%           
=======================================
  Files         168      168           
  Lines        3537     3539    +2     
  Branches     1224     1226    +2     
=======================================
+ Hits         3260     3262    +2     
  Misses        256      256           
  Partials       21       21           
Impacted Files Coverage Δ
...mponents/NotificationInline/NotificationInline.tsx 93.22% <100.00%> (+0.23%) ⬆️

@robinmetral robinmetral requested review from robinmetral and removed request for connor-baer April 24, 2023 15:56
@connor-baer connor-baer added this to the v6.x milestone May 17, 2023
@connor-baer connor-baer requested review from connor-baer and removed request for robinmetral May 17, 2023 13:21
@connor-baer
Copy link
Member

We're putting this change on hold until we have time to document some usage guidelines for the multi-button variant.

@connor-baer connor-baer added the ⛔ do not merge There is a blocker label Jun 2, 2023
@connor-baer connor-baer modified the milestones: v6.x, v7.x Jun 12, 2023
@connor-baer connor-baer modified the milestones: v7.x, v8.x Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants