Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about the @types/react clash to the migration guide #1859

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

robinmetral
Copy link
Contributor

Purpose

Although this isn't a breaking change, the types clash was noticed when upgrading sumup/ze-dashboard, sumup/circuit-ui-form and the CNA template to v6. I think it makes sense to mention in the migration guide.

For context on the types clash, refer to:

Approach and changes

🖊️

Definition of done

n/a

This was noticed in sumup/ze-dashboard, sumup/circuit-ui-form and in the CNA template
@robinmetral robinmetral requested a review from a team as a code owner December 1, 2022 12:36
@robinmetral robinmetral requested review from connor-baer and removed request for a team December 1, 2022 12:36
@sumup-clark
Copy link

sumup-clark bot commented Dec 1, 2022

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2022

⚠️ No Changeset found

Latest commit: 1d5612e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 0:36AM (UTC)

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #1859 (1d5612e) into main (f19a218) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1859   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         172      172           
  Lines        3565     3565           
  Branches     1152     1152           
=======================================
  Hits         3269     3269           
  Misses        276      276           
  Partials       20       20           

@robinmetral robinmetral merged commit 146d76a into main Dec 1, 2022
@robinmetral robinmetral deleted the migration-guide-update branch December 1, 2022 12:55
@robinmetral robinmetral added the 📋 documentation Adds or improves documentation label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 documentation Adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants