Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain with dash in single sign on configuration #7421

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented May 13, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no yes
Fixed tickets fixes sulu/sulu-docs#797 Thx @tic984 for report
Related issues/PRs #7262
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Fix domain with dash in single sign on configuration.

Why?

Symfony normalize Yaml, XML config keys with - always to _ when not explicit defined. The normalizeKeys(false) avoid this: https://symfony.com/doc/current/components/config/definition.html#array-node-options

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label May 13, 2024
@alexander-schranz alexander-schranz force-pushed the bugfix/single-sign-on-configuration branch from 2e20f73 to be95e28 Compare May 13, 2024 10:23
Co-authored-by: Sinisa Valentic <tic984@gmail.com>
@alexander-schranz alexander-schranz force-pushed the bugfix/single-sign-on-configuration branch from be95e28 to 0f908fc Compare May 13, 2024 10:24
@Prokyonn Prokyonn enabled auto-merge (squash) May 13, 2024 10:48
@alexander-schranz alexander-schranz merged commit 61adf77 into sulu:2.6 May 13, 2024
7 of 8 checks passed
@alexander-schranz alexander-schranz deleted the bugfix/single-sign-on-configuration branch May 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants