Refactor phpunit dataprovider to be static #7419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
force-pushed
the
dataprovider_fixups
branch
4 times, most recently
from
c3bec53
to
5d49131
Compare
|
@alexander-schranz Do you have an idea how to tackle the dataprovider in the
|
|
@mamazu let me know when this is ready to review. |
|
@mamazu I personally think the dataprovider in |
|
Yes, this would make the test much easier as well. |
mamazu
force-pushed
the
dataprovider_fixups
branch
from
092a6f1
to
9fb6926
Compare
alexander-schranz
force-pushed
the
dataprovider_fixups
branch
from
9fb6926
to
4622db4
Compare
|
|
||
| $suluNode = new SuluNode($node->reveal()); | ||
|
|
||
| $this->assertSame($nodes, iterator_to_array($suluNode->getSharedSet())); |
There was a problem hiding this comment.
@mamazu if you want to convert a iterable (array / Traversable) to an array you can use [...$suluNode->getSharedSet()] this works with arrays and traversables.
mamazu
force-pushed
the
dataprovider_fixups
branch
from
748d746
to
8afd542
Compare
alexander-schranz
approved these changes
May 13, 2024
|
I think those should be all instances. |
alexander-schranz
approved these changes
May 13, 2024
alexander-schranz
changed the title
|
@mamazu Thank you. Already merged also to 2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixing more dataproviders.
Todo