Using Symfony configuration for webspaces #7218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
changed the title
mamazu
commented
Dec 3, 2023
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->scalarNode('config_dir') | ||
| ->defaultValue('%kernel.project_dir%/config/webspaces') |
There was a problem hiding this comment.
Add this directory to the kernel maybe to also load webspaces from there?
There was a problem hiding this comment.
I don't think we can do that in Sulu code?
2 tasks
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
from
3722ee9
to
dbd4952
Compare
mamazu
commented
Dec 10, 2023
| @@ -36,7 +40,7 @@ | |||
| </navigation> | |||
|
|
|||
| <resource-locator> | |||
| <strategy>short</strategy> | |||
There was a problem hiding this comment.
Is that a real strategy? If so, then I couldn't find any classes implementing the strategy.
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
from
8897e86
to
cfeda49
Compare
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
from
9e5d959
to
8cc538f
Compare
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
from
8cc538f
to
e90abb2
Compare
mamazu
commented
Feb 27, 2024
src/Sulu/Component/Webspace/Tests/Unit/Manager/WebspaceCollectionCache.php
Show resolved
Hide resolved
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
from
e09f570
to
bf67a98
Compare
mamazu
commented
Mar 9, 2024
| @@ -17,7 +17,7 @@ interface SystemStoreInterface | |||
| { | |||
| public function getSystem(): ?string; | |||
|
|
|||
| public function setSystem(string $system): void; | |||
| public function setSystem(?string $system): void; | |||
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
4 times, most recently
from
8dd5614
to
1793fd1
Compare
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
from
1793fd1
to
fbb3645
Compare
Migration guide
<webspace xmlns="http://schemas.sulu.io/webspace/webspace"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://schemas.sulu.io/webspace/webspace http://schemas.sulu.io/webspace/webspace-1.1.xsd">and replace it with this: <services:container xmlns="http://example.org/schema/dic/sulu_website"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:services="http://symfony.com/schema/dic/services"
xsi:schemaLocation="http://symfony.com/schema/dic/services
https://symfony.com/schema/dic/services/services-1.0.xsd"
>
<config>
<webspace>
</config>
</services:container> |
mamazu
changed the title
mamazu
changed the title
mamazu
force-pushed
the
using_symonfy_for_webspaces
branch
from
3580ad9
to
1ccf181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Creating a way to configure webspaces with Symfony configuration.
Why?
Currently Sulu has it's own XML parser for webspace configs. This is a lot of maintenance and hard to extend. Using the Symfony config solves both
Example Usage
Just write your configs like before. But now you can also use YAML and PHP.
To Do
Create a documentation PR
Make sublocales possible in the config (at most two)
Document this ^
Document how to extend the configuration
It should work with the same configuration as before
Making the
WebspaceCollectionread onlyChecking all Exceptions have been turned into validation