Move admin build to dist directory #6958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/move-admin-build-to-dist-directory
branch
from
7dac9c5
to
b35a0f2
Compare
|
@chirimoya Did mention that he would maybe go with |
would go with |
|
@chirimoya Should we do this in I did lately setup a assetmapper project there a different directory is also used which we need avoid for our build: Webpack Encore uses: One other way could be we use something like |
|
@alexander-schranz let's discuss on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Move admin build to dist directory.
Why?
Avoid conflict with webpack encore or asset mapper.
Webpack Encore uses:
public/buildAssetmapper uses:
public/assets