Add command to generate multiple database migrations #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Sulu/Bundle/MigrationBundle/Command/MigrationDiffCommand.php
Outdated
Show resolved
Hide resolved
Comment on lines
+125
to
+136
| private function replaceAbortWithSkip(): void | ||
| { | ||
| $finder = new Finder(); | ||
| $finder->files()->in(\dirname(__DIR__) . '/Migrations')->name('Version*.php'); | ||
|
|
||
| foreach ($finder as $file) { | ||
| \file_put_contents( | ||
| $file->getPathname(), | ||
| \str_replace('abortIf', 'skipIf', $file->getContents()) | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
This should not be required as we should make sure that PostgreSQL, MySQL and MariaDB migrations life each in an own directory. And only the directory which is relevant is really loaded for the migrations. As skipIf migrations will trigger are a warning message in the doctrine migration command always, which we should avoid.
Comment on lines
+22
to
+27
| // this up() migration is auto-generated, please modify it to your needs | ||
| $this->skipIf( | ||
| !$this->connection->getDatabasePlatform() instanceof \Doctrine\DBAL\Platforms\MySQL80Platform, | ||
| "Migration can only be executed safely on '\Doctrine\DBAL\Platforms\MySQL80Platform'." | ||
| ); | ||
|
|
There was a problem hiding this comment.
Just example migration file which should be replaced in future.
Comment on lines
+22
to
+26
| // this up() migration is auto-generated, please modify it to your needs | ||
| $this->skipIf( | ||
| !$this->connection->getDatabasePlatform() instanceof \Doctrine\DBAL\Platforms\PostgreSQL100Platform, | ||
| "Migration can only be executed safely on '\Doctrine\DBAL\Platforms\PostgreSQL100Platform'." | ||
| ); |
There was a problem hiding this comment.
Just example migration file which should be replaced in future into more splitted files.
Comment on lines
+22
to
+26
| // this up() migration is auto-generated, please modify it to your needs | ||
| $this->skipIf( | ||
| !$this->connection->getDatabasePlatform() instanceof \Doctrine\DBAL\Platforms\MariaDb1027Platform, | ||
| "Migration can only be executed safely on '\Doctrine\DBAL\Platforms\MariaDb1027Platform'." | ||
| ); |
There was a problem hiding this comment.
Just example migration file which should be replaced in future into more splitted files.
|
Any updates on this? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add command to generate multiple database migrations
Why?
To simplify the process of Sulu updates whatever database is used
After some discussion about the update process with @luca-rath I thought I hack together some prototype how we could easily generate doctrine migrations for different databases (postgresql, mysql, mariadb)..
Example Usage
cd src/Sulu/Bundle/MigrationBundle/Resources/docker/ docker compose up bin/console sulu:migration:migration-diffTo Do
Even this is a feature for
2.6all migration files between minor version jumps should be there ownVersion...phpfile so from whaterver2.xversion to2.6somebody is jumping they can directly use the doctrine migrations.All migrations before
2.6need first a check if they really need to be executed, as a project itself could already that field in a custom migration added.