Upgrade react to version 18 and react-leaflet to version 4 #6689
Conversation
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
feature/upgrade-react
branch
from
a99cfdf
to
0c7f0e0
Compare
UPGRADE.md
Outdated
| @@ -2,6 +2,17 @@ | |||
|
|
|||
| ## 2.5.0 | |||
|
|
|||
| ### JS Dependencies update | |||
|
|
|||
| Sulu requires now new versions of the following JS packages: | |||
There was a problem hiding this comment.
would add this to the existing list once #6688 is merged
| "leaflet": "^1.5.1", | ||
| "react-leaflet": "^3.2.0" | ||
| "leaflet": "^1.8", | ||
| "react-leaflet": "^4.0.1" |
There was a problem hiding this comment.
the react-leaflet changelog sounds like we cannot use whenCreated here anymore:
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh thats funny. Need to check it out for me all did work as expected while testing.
| @@ -78,8 +78,8 @@ | |||
| "postcss-nested": "^4.2.3", | |||
| "postcss-simple-vars": "^5.0.2", | |||
| "raw-loader": "^4.0.0", | |||
| "react": "^17.0.0", | |||
| "react-dom": "^17.0.0", | |||
| "react": "^18.0.0", | |||
There was a problem hiding this comment.
as far as i understand, we cannot really use any new react features together while still using our outdated version of mobx (#6343). but hopefully it should also not cause any issues 🙂
alexander-schranz
force-pushed
the
feature/upgrade-react
branch
from
39e6fbc
to
c11c2d3
Compare
|
We will not yet update to react 18. first we would need to make sure https://github.com/wojtekmaj/enzyme-adapter-react-17 is supporting it. |
|
https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl /cc @sulu/core-team |
What's in this PR?
Upgrade react to version 18.
Why?
Usage of the latest react version.