Index and deindex shadow documents #6309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove from structure Change use order Add licence
plozmun
force-pushed
the
feature/index-shadow-documents
branch
from
8dd0c9b
to
b525578
Compare
niklasnatter
changed the title
niklasnatter
reviewed
Nov 9, 2021
| use Sulu\Component\DocumentManager\Events; | ||
| use Symfony\Component\EventDispatcher\EventSubscriberInterface; | ||
|
|
||
| class ShadowStructureSubscriber implements EventSubscriberInterface |
There was a problem hiding this comment.
Thank you for working on this! I think I would prefer to include this logic in the existing Sulu\Bundle\PageBundle\Search\EventSubscriber\StructureSubscriber as that class already registers all required listeners and things cannot get inconsistent 🙂
alexander-schranz
added
the
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Index or reindex shadow documents with original locale
Why?
Shadow pages are not being indexed
I don't know if WorkflowStageBehavior must be taken in count in this case