Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpstan to new version #217

Closed

Conversation

alexander-schranz
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1760904827

  • 21 of 21 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1745433092: 0.0%
Covered Lines: 2076
Relevant Lines: 2076

💛 - Coveralls

Comment on lines +81 to +82
* TODO there is an edge case where locale: null is given and locale: null returned by DimensionContentQueryEnhancer.
* Find a way to set locale return type by
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan/phpstan#5591 (comment)

Beneath is correctly handled by phpstan but it does add an other bounded error.

@alexander-schranz alexander-schranz deleted the feature/phpstan-update branch April 24, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants