Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 7 #2133

Merged
merged 1 commit into from Jul 26, 2022
Merged

Upgrade to Rails 7 #2133

merged 1 commit into from Jul 26, 2022

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 13, 2022

Why was this change made?

How was this change tested?

Which documentation and/or configurations were updated?

@jcoyne jcoyne force-pushed the rails7 branch 2 times, most recently from 1c0d65f to 69a7095 Compare January 13, 2022 16:18
@jcoyne
Copy link
Contributor Author

jcoyne commented Jan 13, 2022

With this change, we can no longer upload files.

We get:

10:42:38 web.1  | Started POST "/rails/active_storage/direct_uploads" for 127.0.0.1 at 2022-01-13 10:42:38 -0600
10:42:38 web.1  | Processing by ActiveStorage::DirectUploadsController#create as JSON
10:42:38 web.1  |   Parameters: {"blob"=>{"filename"=>"0001-ljs495.xml", "content_type"=>"text/xml", "byte_size"=>156301, "checksum"=>"dQUMlZBqmdVJEK3ghf2A3A=="}, "direct_upload"=>{"blob"=>{"filename"=>"0001-ljs495.xml", "content_type"=>"text/xml", "byte_size"=>156301, "checksum"=>"dQUMlZBqmdVJEK3ghf2A3A=="}}}
10:42:38 web.1  | Completed 500 Internal Server Error in 46ms (ActiveRecord: 0.0ms | Allocations: 9479)
10:42:38 web.1  |
10:42:38 web.1  |
10:42:38 web.1  |
10:42:38 web.1  | ActiveStorage::InvalidDirectUploadTokenError (ActiveStorage::InvalidDirectUploadTokenError):
10:42:38 web.1  |
10:42:38 web.1  | activestorage (7.0.1) lib/active_storage/direct_upload_token.rb:16:in `verify_direct_upload_token'
10:42:38 web.1  | activestorage (7.0.1) app/controllers/active_storage/direct_uploads_controller.rb:20:in `verified_service_name'
10:42:38 web.1  | activestorage (7.0.1) app/controllers/active_storage/direct_uploads_controller.rb:10:in `create'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
10:42:38 web.1  | actionpack (7.0.1) lib/abstract_controller/base.rb:214:in `process_action'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/rendering.rb:53:in `process_action'
10:42:38 web.1  | actionpack (7.0.1) lib/abstract_controller/callbacks.rb:234:in `block in process_action'
10:42:38 web.1  | activesupport (7.0.1) lib/active_support/callbacks.rb:107:in `run_callbacks'
10:42:38 web.1  | actionpack (7.0.1) lib/abstract_controller/callbacks.rb:233:in `process_action'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/rescue.rb:22:in `process_action'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/instrumentation.rb:67:in `block in process_action'
10:42:38 web.1  | activesupport (7.0.1) lib/active_support/notifications.rb:206:in `block in instrument'
10:42:38 web.1  | activesupport (7.0.1) lib/active_support/notifications/instrumenter.rb:24:in `instrument'
10:42:38 web.1  | activesupport (7.0.1) lib/active_support/notifications.rb:206:in `instrument'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/instrumentation.rb:66:in `process_action'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/params_wrapper.rb:259:in `process_action'
10:42:38 web.1  | activerecord (7.0.1) lib/active_record/railties/controller_runtime.rb:27:in `process_action'
10:42:38 web.1  | actionpack (7.0.1) lib/abstract_controller/base.rb:151:in `process'
10:42:38 web.1  | actionview (7.0.1) lib/action_view/rendering.rb:39:in `process'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/live.rb:266:in `block (2 levels) in process'
10:42:38 web.1  | activesupport (7.0.1) lib/active_support/concurrency/share_lock.rb:162:in `sharing'
10:42:38 web.1  | activesupport (7.0.1) lib/active_support/dependencies/interlock.rb:37:in `running'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/live.rb:258:in `block in process'
10:42:38 web.1  | actionpack (7.0.1) lib/action_controller/metal/live.rb:343:in `block in new_controller_thread'

It is possibly hitting:
rails/rails#43971

@jcoyne
Copy link
Contributor Author

jcoyne commented Jan 31, 2022

This may have fixed it: rails/rails#44287, but it hasn't been released yet.

@jcoyne jcoyne force-pushed the rails7 branch 3 times, most recently from d154c4a to b2b43d2 Compare July 25, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants