Provide validation for file ids that are not formatted like a URI #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to find places where we have non-standard URI creation
|
Why not fix the problem and make it cocina validation? It is clearer to have all model validation in a single location. |
|
@justinlittman we use the cocina models in sdr-api that use encoded identifiers, not URIs. |
|
Ah, right. |
ndushay
approved these changes
Sep 9, 2022
| @@ -28,6 +28,10 @@ def generate_or_existing_file_id | |||
| "#{ID_NAMESPACE}/file/#{druid}-#{resource_id}/#{file_id}" | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Please consider adding a comment to bring the content of the PR discussion into the code. Something like
# this validation is useful for (e.g. sdr-api that uses) encoded identifiers, not URIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably merge sul-dlss/sdr-api#494 first or this will trigger a lot.
Why was this change made? 馃
This will allow us to find places where we have non-standard URI creation
How was this change tested? 馃え
CI