Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidekiq web UI #2645

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Fix sidekiq web UI #2645

merged 1 commit into from
Apr 2, 2021

Conversation

mjgiarlo
Copy link
Member

@mjgiarlo mjgiarlo commented Apr 2, 2021

Fixes #2638

Why was this change made?

This PR follows the instructions from the Sidekiq docs: https://github.com/mperham/sidekiq/wiki/Monitoring#rails-api-application-session-configuration

It also adds a SECRET_KEY_BASE to the web docker-compose service, which is required now that we switched to RAILS_ENV=production. This value is not used anywhere else, so it seems safe to have here. No .env hijinks needed, I do not think.

How was this change tested?

CI, locally

Which documentation and/or configurations were updated?

None

Fixes #2638

This PR follows the instructions from the Sidekiq docs: https://github.com/mperham/sidekiq/wiki/Monitoring#rails-api-application-session-configuration

It also adds a SECRET_KEY_BASE to the web docker-compose service, which is required now that we switched to RAILS_ENV=production. This value is not used anywhere else, so it seems safe to have here. No .env hijinks needed, I do not think.
@mjgiarlo mjgiarlo merged commit 2ac9d78 into main Apr 2, 2021
@mjgiarlo mjgiarlo deleted the fix-sidekiq-web#2638 branch April 2, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidekiq UI won't display (dor-services-app and sdr-api)
3 participants