Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code gardening #609

Merged
merged 3 commits into from Oct 2, 2020
Merged

Code gardening #609

merged 3 commits into from Oct 2, 2020

Conversation

koppen
Copy link
Member

@koppen koppen commented Sep 14, 2020 •
edited

Build failure appears to be caused by rubocop/rubocop#8642

@koppen koppen changed the base branch from master to main October 1, 2020 12:47
@koppen
Use $stdout instead of STDOUT
74fecaa 
So sayeth Rubocop:

> C: Style/GlobalStdStream: Use $stdout instead of STDOUT.
>     logger           = ActiveSupport::Logger.new(STDOUT)
@koppen
Don't use blocks for defaults
e04899c 
Rubocop recommends the basic syntax instead, which does make sense.
@koppen
Reduce superfluous whitespace
836c011
@koppen
Copy link
Member Author

koppen commented Oct 2, 2020

Codacy says:

Up to standards. A positive pull request.

even though it says "unable to analyse" here.

@koppen koppen merged commit 10f625e into main Oct 2, 2020
@koppen koppen deleted the code_gardening branch October 2, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@koppen