Globalnet not running in E2E #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The E2E jobs intended to install/run Globalnet are not doing so. This is b/c the E2E GHA needs to specify the "matrix.globalnet" var in the "using" statement. This was broken by submariner-io@6cd0a39 when the globalnet option was removed from "extra-toggles". Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr3009/tpantelis/fix_globalnet_e2e_gha |
tpantelis
added
backport
aswinsuryan
approved these changes
May 17, 2024
skitt
approved these changes
May 21, 2024
|
🤖 Closed branches: [z_pr3009/tpantelis/fix_globalnet_e2e_gha] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E jobs intended to install/run Globalnet are not doing so. This is b/c the E2E GHA needs to specify the
matrix.globalnetvar in theusingstatement. This was broken by 6cd0a39 when theglobalnetoption was removed fromextra-toggles.