Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint 1.46.2 -> 1.47.3 #899

Merged
merged 3 commits into from Aug 8, 2022
Merged

Bump golangci-lint 1.46.2 -> 1.47.3 #899

merged 3 commits into from Aug 8, 2022

Conversation

dfarrell07
Copy link
Member

@dfarrell07 dfarrell07 commented Aug 2, 2022 •
edited

https://github.com/golangci/golangci-lint/releases/tag/v1.47.3
golangci/golangci-lint@v1.46.2...v1.47.3

This resolves golang 1.18 limitations that we've discussed.

golangci/golangci-lint/pull/3001

Depends on #900
Signed-off-by: Daniel Farrell dfarrell@redhat.com

@dfarrell07
Bump golangci-lint 1.46.2 -> 1.47.3
5f0d973 
https://github.com/golangci/golangci-lint/releases/tag/v1.47.3
golangci/golangci-lint@v1.46.2...v1.47.3

This resolves golang 1.18 limitations that we've discussed.

golangci/golangci-lint/pull/3001

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
@dfarrell07 dfarrell07 added the maintenance Small tasks related to ongoing maintenance label Aug 2, 2022
@dfarrell07 dfarrell07 added this to In progress in Submariner Project 0.14 via automation Aug 2, 2022
@dfarrell07 dfarrell07 self-assigned this Aug 2, 2022
@submariner-bot
Copy link

🤖 Created branch: z_pr899/dfarrell07/golint_1473

@dfarrell07 dfarrell07 added the lint-projects Lint consuming projects label Aug 2, 2022
@dfarrell07 dfarrell07 mentioned this pull request Aug 2, 2022
Closed
@dfarrell07
Copy link
Member Author

Interesting new failures. Raised #900 to track.

@tpantelis
Copy link
Contributor

Depends on submariner-io/subctl#199

Won't we have a chicken and the egg thing where linting will fail and gate submariner-io/subctl#199 which will gate this PR but this PR is needed to unblock submariner-io/subctl#199? I think we need to merge this PR first and fix up subctl et al after.

@dfarrell07
Copy link
Member Author

Depends on submariner-io/subctl#199

Won't we have a chicken and the egg thing where linting will fail and gate submariner-io/subctl#199 which will gate this PR but this PR is needed to unblock submariner-io/subctl#199? I think we need to merge this PR first and fix up subctl et al after.

Yep, you're right, this will need to go in before the subctl nilerr PR. I updated the Depends-on line here to track the gosec issues, which I think we should fix before this is merged.

@dfarrell07 dfarrell07 mentioned this pull request Aug 3, 2022
Merged
@github-actions github-actions bot removed the dependent label Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This PR/issue depends on:

@dfarrell07 dfarrell07 moved this from In progress to In Review in Submariner Project 0.14 Aug 4, 2022
@tpantelis tpantelis mentioned this pull request Aug 8, 2022
Merged
@skitt skitt mentioned this pull request Aug 8, 2022
Merged
@tpantelis tpantelis merged commit e0146f0 into submariner-io:devel Aug 8, 2022
Submariner Project 0.14 automation moved this from In Review to Done Aug 8, 2022
@submariner-bot
Copy link

🤖 Closed branches: [z_pr899/dfarrell07/golint_1473]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyechiel nyechiel nyechiel approved these changes

@tpantelis tpantelis tpantelis approved these changes

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees

@dfarrell07 dfarrell07

Labels
lint-projects Lint consuming projects maintenance Small tasks related to ongoing maintenance
Projects
No open projects
Submariner Project 0.14
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dfarrell07 @submariner-bot @tpantelis @nyechiel