Use cloud-provider-kind instead of MetalLB #1622
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kind has a cloud-provider which can take care of LoadBalancer-type services; this works fine with LB-mode Submariner, so use that instead of MetalLB. Currently the command is installed as cmd, which is why it is renamed during container construction. This is fixed for the next release of the cloud-provider. cloud-provider-kind runs in the foreground, so this wraps it in a container run alongside the kind clusters, on the host network. The container is stopped on cleanup. The dependency version will be tracked using dependabot. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1622/skitt/cloud-provider-kind |
tpantelis
approved these changes
Apr 18, 2024
|
Switching to draft because this leaves haproxy containers running (and shouldn’t). |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
I think we should consider keeping MetalLB as well since it is the default LB provider for baremetal. Do you think we can support both methods? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind has a cloud-provider which can take care of LoadBalancer-type services; this works fine with LB-mode Submariner, so use that instead of MetalLB.
Currently the command is installed as cmd, which is why it is renamed during container construction. This is fixed for the next release of the cloud-provider.
cloud-provider-kind runs in the foreground, so this wraps it in a container run alongside the kind clusters, on the host network. The container is stopped on cleanup.
The dependency version will be tracked using dependabot.