Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bump node-fetch dep to pick up security release #147

Merged
merged 3 commits into from Apr 26, 2023
Merged

fix: Bump node-fetch dep to pick up security release #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
672dc5f
fix: Bump node-fetch dep to pick up security release
max-stytch Jul 7, 2022
fd96708
bump cont.
max-stytch Apr 26, 2023
63a16bb
Merge remote-tracking branch 'origin/main' into max/bump-node-fetch
max-stytch Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -53,6 +53,11 @@
"isomorphic-unfetch": "^3.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't dug too deep into the issue, but "Up to (excluding) 3.1.1" makes me think we should also bump our direct dependency. But I may just be misunderstanding the override system with multiple versions of the same dependency around.

Suggested change
"isomorphic-unfetch": "^3.1.0",
"isomorphic-unfetch": "^3.1.1",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look into node-fetch and the reported issue isn't fixed in the latest - opened node-fetch/node-fetch#1599

"jose": "^4.6.0"
},
"overrides": {
"isomorphic-unfetch": {
"node-fetch": "2.6.9"
}
},
"eslintConfig": {
"extends": "airbnb",
"env": {
Expand Down