Add Sports namespace (#1538)

* Update unreleased/docs and move sport namespace to unreleased folder

* Deprecate ::Football

* Separate v1.9.3 deprecations from current version deprecaions

* Update Faker::Construction documentation

* Update CHANGELOG

* Update CHANGELOG

CHANGELOG.md

@@ -8,10 +8,15 @@
 
 ### Deprecation
 
+- [PR #1538](https://github.com/stympy/faker/pull/1538) Add Sports namespace [@vbrazo](https://github.com/vbrazo)
+  - Deprecates `::Football`
+
 ### Documentation
 
 ### Feature Request
 
+- [PR #1537](https://github.com/stympy/faker/pull/1537) Adds the Faker::Sports::Basketball generator [@ecbrodie](https://github.com/ecbrodie)
+
 ### Suggestion
 
 ### Update/add locales

doc/default/construction.md

@@ -8,4 +8,16 @@ Faker::Construction.material #=> "Wood"
 
 # Random subcontract category
 Faker::Construction.subcontract_category #=> "Curb & Gutter"
+
+# Random heavy_equipment
+Faker::Construction.heavy_equipment #=> "Excavator"
+
+# Random trade
+Faker::Construction.trade #=> "Carpenter"
+
+# Random standard_cost_code
+Faker::Construction.standard_cost_code #=> "1-000 - Purpose"
+
+# Random role
+Faker::Construction.role #=> "Engineer"
 ```

doc/unreleased/default/construction.md

@@ -8,4 +8,16 @@ Faker::Construction.material #=> "Wood"
 
 # Random subcontract category
 Faker::Construction.subcontract_category #=> "Curb & Gutter"
+
+# Random heavy_equipment
+Faker::Construction.heavy_equipment #=> "Excavator"
+
+# Random trade
+Faker::Construction.trade #=> "Carpenter"
+
+# Random standard_cost_code
+Faker::Construction.standard_cost_code #=> "1-000 - Purpose"
+
+# Random role
+Faker::Construction.role #=> "Engineer"
 ```

doc/unreleased/sports/football.md

@@ -0,0 +1,15 @@
+# Faker::Sports::Football
+
+Available since version 1.9.0.
+
+```ruby
+Faker::Sports::Football.team #=> "Manchester United"
+
+Faker::Sports::Football.player #=> "Lionel Messi"
+
+Faker::Sports::Football.coach #=> "Jose Mourinho"
+
+Faker::Sports::Football.competition #=> "FIFA World Cup"
+
+Faker::Sports::Football.position #=> "Defensive Midfielder"
+```

lib/faker/deprecate/unreleased/football.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Faker
+  class Football
+    class << self
+      extend Gem::Deprecate
+
+      def team
+        Faker::Sports::Football.team
+      end
+
+      def player
+        Faker::Sports::Football.player
+      end
+
+      def coach
+        Faker::Sports::Football.coach
+      end
+
+      def competition
+        Faker::Sports::Football.competition
+      end
+
+      def position
+        Faker::Sports::Football.position
+      end
+
+      deprecate :team, 'Faker::Sports::Football.team', 2019, 04
+      deprecate :player, 'Faker::Sports::Football.player', 2019, 04
+      deprecate :coach, 'Faker::Sports::Football.coach', 2019, 04
+      deprecate :competition, 'Faker::Sports::Football.competition', 2019, 04
+      deprecate :position, 'Faker::Sports::Football.position', 2019, 04
+    end
+  end
+end

lib/faker/sports/basketball.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Faker
-  module Sports
+  class Sports
     class Basketball < Base
       class << self
         def team

lib/faker/sports/football.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module Faker
+  class Sports
+    class Football < Base
+      class << self
+        def team
+          fetch('football.teams')
+        end
+
+        def player
+          fetch('football.players')
+        end
+
+        def coach
+          fetch('football.coaches')
+        end
+
+        def competition
+          fetch('football.competitions')
+        end
+
+        def position
+          fetch('football.positions')
+        end
+      end
+    end
+  end
+end

test/deprecate/unreleased/test_deprecate_football.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+require_relative '../../test_helper'
+
+class TestDeprecateFootball < Test::Unit::TestCase
+  def setup
+    @tester = Faker::Football
+  end
+
+  def test_team
+    assert @tester.team.match(/\w+/)
+  end
+
+  def test_player
+    assert @tester.player.match(/\w+/)
+  end
+
+  def test_coach
+    assert @tester.coach.match(/\w+/)
+  end
+
+  def test_competition
+    assert @tester.competition.match(/\w+/)
+  end
+
+  def test_position
+    assert @tester.position.match(/\w+/)
+  end
+end

test/deprecate/test_deprecate_aqua_teen_hunger_force.rb → test/deprecate/v1.9.3/test_deprecate_aqua_teen_hunger_force.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateAquaTeenHungerForce < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_back_to_the_future.rb → test/deprecate/v1.9.3/test_deprecate_back_to_the_future.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateBackToTheFuture < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_bitcoin.rb → test/deprecate/v1.9.3/test_deprecate_bitcoin.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateBitcoin < Test::Unit::TestCase
   def test_address

test/deprecate/test_deprecate_bojack_horseman.rb → test/deprecate/v1.9.3/test_deprecate_bojack_horseman.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateBojackHorseman < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_breaking_bad.rb → test/deprecate/v1.9.3/test_deprecate_breaking_bad.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateBreakingBad < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_buffy.rb → test/deprecate/v1.9.3/test_deprecate_buffy.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateBuffy < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_cat.rb → test/deprecate/v1.9.3/test_deprecate_cat.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateCat < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_community.rb → test/deprecate/v1.9.3/test_deprecate_community.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateCommunity < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_dog.rb → test/deprecate/v1.9.3/test_deprecate_dog.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateDog < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_dota.rb → test/deprecate/v1.9.3/test_deprecate_dota.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateDota < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_dr_who.rb → test/deprecate/v1.9.3/test_deprecate_dr_who.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateDrWho < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_dragon_ball.rb → test/deprecate/v1.9.3/test_deprecate_dragon_ball.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestFakerDragonBall < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_dumb_and_dumber.rb → test/deprecate/v1.9.3/test_deprecate_dumb_and_dumber.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateDumbAndDumber < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_dune.rb → test/deprecate/v1.9.3/test_deprecate_dune.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateDune < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_elder_scrolls.rb → test/deprecate/v1.9.3/test_deprecate_elder_scrolls.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateElderScrolls < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_ethereum.rb → test/deprecate/v1.9.3/test_deprecate_ethereum.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateEthereum < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_fallout.rb → test/deprecate/v1.9.3/test_deprecate_fallout.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateFallout < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_family_guy.rb → test/deprecate/v1.9.3/test_deprecate_family_guy.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateFamilyGuy < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_friends.rb → test/deprecate/v1.9.3/test_deprecate_friends.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateFriends < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_game_of_thrones.rb → test/deprecate/v1.9.3/test_deprecate_game_of_thrones.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateGameOfThrones < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_harry_potter.rb → test/deprecate/v1.9.3/test_deprecate_harry_potter.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateHarryPotter < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_heroes_of_the_storm.rb → test/deprecate/v1.9.3/test_deprecate_heroes_of_the_storm.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateHeroesOfTheStorm < Test::Unit::TestCase
   def setup

test/deprecate/test_deprecate_hey_arnold.rb → test/deprecate/v1.9.3/test_deprecate_hey_arnold.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../test_helper'
+require_relative '../../test_helper'
 
 class TestDeprecateHeyArnold < Test::Unit::TestCase
   def setup