Split render #2701
Open
Split render #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Refactoring lib/renderer.js code by splitting the
render()code into several smaller functionsNote : this patch includes also #2700 . I can rebase it on dev if I am asked for. But if #2700 is merged, then this one could be merged right after
Why:
Some usages might not need the full compilation process, e.g.: Getting all values defined in a stylus file (and what it
@import) only need parsing and evaluation. But the Renderer class does some nice setup and bundles all the compile steps in a neat wayHow:
Provide each step as a public method.
Checklist:
Not sure how to change the change logs, I am waiting for comments.