Do not target comma's that are between quotes or parentheses #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes a issue with the normalizer whereby the normalize would target comma's that are within quotes or parantheses. This broke CSS selectors that uses attribute selectors that e.g. specified a specifc rgba value which uses comma's as delimeter. - Added a test-cases to reflect this change. - `[style="color: rgb(0, 186, 124)"]` won't be normalized to `[style="color: rgb(0,\n 186,\n 124)"]`.
Gusted
changed the title
|
Is this close to being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes a issue with the normalizer whereby it would target comma's that are within quotes or parentheses.
Why:
This broke CSS selectors that uses attribute selectors that e.g. specified a specific RGBA value which uses comma's as delimiter.
How:
Changing from
,to a regex solution that avoids matching comma's that are between quotes and parentheses. The splitting with regex somehow introduced that their could beundefinedentries within the parts array, so now it first checked if it isn't aundefinedentry.Checklist:
[style="color: rgb(0, 186, 124)"]won't be normalized to[style="color: rgb(0,\n 186,\n 124)"].