Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DepsResolver.visitImport path isNull check #2627

Closed
wants to merge 1 commit into from
Closed

fix: DepsResolver.visitImport path isNull check #2627

wants to merge 1 commit into from

Conversation

trailskr
Copy link

@trailskr trailskr commented Aug 26, 2021 •
edited by iChenLei

fixed potential error:

I found a bug: I have next code, that rises an error:

@import url('https://fonts.googleapis.com/css2?family=Source+Sans+Pro:wght@400;600&display=swap')

How: within the meaning of code

Checklist:

  • Documentation
  • Unit Tests
  • Code complete

@iChenLei iChenLei self-requested a review August 26, 2021 15:44
@iChenLei
Copy link
Member

iChenLei commented Aug 26, 2021 •
edited

Please add unit test, even it's a simple fix.

CI failed ? https://github.com/stylus/stylus/pull/2627/checks?check_run_id=3434596058

@groenroos groenroos mentioned this pull request Sep 5, 2021
Merged
3 tasks
@iChenLei
Copy link
Member

closed via #2632 , but thanks for your pr, looking foward more contribution from you !

@iChenLei iChenLei closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iChenLei iChenLei Awaiting requested review from iChenLei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trailskr @iChenLei