Fix maths for lib/functions/adjust() #2451
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of the returned value is awkward in case of a percentage of lightness.
However, as this error is here since quite a long time, fixing will surely break stuff...
Sorry about the double PR... :/
Take
hsl.l = 60
. Increasing it's value of 50% should give as a result 90%, and 30% when decreasing it.The decreasing part is OK, however increasing the lightness by 50% gives 80%.
The current code, when used with percentages and lightness is equivalent to:
Numerically, with values as given above (
val = 50
,hsl.l = 60
):Thus, if we want to have 90% as a result, only the
else
part is valid.