Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PnP package resolution support #273

Merged
merged 10 commits into from
Nov 3, 2021
Merged

feat: PnP package resolution support #273

merged 10 commits into from
Nov 3, 2021

Conversation

adalinesimonian
Copy link
Member

@adalinesimonian adalinesimonian commented Oct 22, 2021

Resolves #272

Allows for resolving Stylelint installed using Yarn with PnP, bypassing the need for Yarn to patch vscode-stylelint's configuration as it does now.

PnP resolution logic

@adalinesimonian adalinesimonian marked this pull request as ready for review October 22, 2021 22:51
@adalinesimonian adalinesimonian added status: wip is being worked on by someone and removed status: needs discussion labels Oct 22, 2021
@adalinesimonian
Copy link
Member Author

Tests are failing in CI but are working locally for me. Going to investigate tomorrow.

@adalinesimonian
Copy link
Member Author

Failing tests were due to a bug that's been patched now in #285.

PR is ready for review!

@adalinesimonian adalinesimonian added For Milestone Issue and removed status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules labels Oct 28, 2021
@adalinesimonian adalinesimonian added this to Review in progress in Rolling Work Tracking Oct 29, 2021
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Rolling Work Tracking automation moved this from Review in progress to Reviewer approved Nov 3, 2021
@adalinesimonian adalinesimonian merged commit 65a6a06 into main Nov 3, 2021
Rolling Work Tracking automation moved this from Reviewer approved to Done Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support resolving Stylelint using PnP
3 participants