Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream types #262

Merged
merged 2 commits into from Oct 11, 2021
Merged

Use upstream types #262

merged 2 commits into from Oct 11, 2021

Conversation

adalinesimonian
Copy link
Member

Closes #256

  • Pulls down latest Stylelint 14 with types added in Add TypeScript type definitions stylelint#5582
  • Replaces typedef statements with declarations file
  • Remove TypeScript error workarounds that are no longer necessary
  • Remove code that is based around old Stylelint types
  • Remove type download and lint script

@adalinesimonian
refactor: use upstream types directly w/o script
9f0dbd0 
Made possible by stylelint/stylelint#5582
@adalinesimonian
fix: avoid typescript error, conform to new types
6a8e2c7 
Disables are no longer reported directly on results and are now reported
just like other rules.
@adalinesimonian adalinesimonian added upstream relates to an upstream package type: refactor an improvement to the code structure labels Oct 11, 2021
@adalinesimonian adalinesimonian added this to the v1.0.0 milestone Oct 11, 2021
@adalinesimonian adalinesimonian self-assigned this Oct 11, 2021
@adalinesimonian adalinesimonian linked an issue Oct 11, 2021 that may be closed by this pull request
Upstream Stylelint types are inconsistent #256
Closed
@adalinesimonian adalinesimonian merged commit 1cfd8a0 into v1 Oct 11, 2021
@adalinesimonian adalinesimonian deleted the v1-#256-use-upstream-types branch October 11, 2021 20:01
@adalinesimonian adalinesimonian added For Milestone Issue and removed upstream relates to an upstream package type: refactor an improvement to the code structure labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adalinesimonian adalinesimonian

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Upstream Stylelint types are inconsistent
1 participant
@adalinesimonian