feat!: Upgrade to Stylelint 14 馃帀 #254
Conversation
Closes #233 - Stylelint dependency changed to point to v14 branch on GitHub (Will need to be changed to the packaged version once Stylelint 14 is published to npm.) - Default values for `validate` and `snippet` options set to `['css', 'postcss']` - Removed `syntax` option - Removed `configOverrides` option - Documented changes and provided migration path in readme - Made appropriate changes in tests - Removed tests for removed features
There was a problem hiding this comment.
Same, looks good to me, will install this v1 branch over the weekend to give it a run, thanks a bunch @adalinesimonian, brilliant work 馃挴
package.json
Outdated
| "@stylelint/postcss-css-in-js": "^0.37.2", | ||
| "@stylelint/postcss-markdown": "^0.36.2", |
There was a problem hiding this comment.
I don't think either of these packages are compatible with PostCSS@8.
The markdown and HTML packages will also be deprecated in favour of none-scoped names as we only scoped them as we thought access to the unscoped versions was lost but we access the packages now. Probably best sticking with postcss-scss for tests. Or at least skipping the HTML and markdown tests until the unscoped and PostCSS@8-compatible versions are ready.
And the monolithic CSS-in-JS package is going to be deprecated in favour of packages that focus on single CSS-in-JS libraries, like styled-component, Stitches or one of the other fifty plus.
There was a problem hiding this comment.
I've temporarily removed html and markdown tests in b94dca9. What would be a good replacement package for the css-in-js tests?
There was a problem hiding this comment.
Unfortunately, there isn't one right now. We're in a chicken and egg situation where we need new syntax packages for version 14 but people need version 14 to write those new syntax packages.
I'm going to dig into custom syntax compatibility for stylelint/stylelint#5563, as I'm surprised the tests passed here. Perhaps some of the existing packages are more compatible than I thought. I'll keep you posted.
There was a problem hiding this comment.
It turns out that these syntaxes are more compatible with PostCSS@8 than we thought.
However, postcss-html and postcss-markdown are currently unmaintained. If you do use them in your tests, use the unforked version of postcss-markdown as we'll be deprecating @stylelint/postcss-markdown.
We won't be deprecating @stylelint/postcss-css-in-js until there are alternative syntaxes (specific to individual CSS-in-JS libraries) available. So you can continue to use it in your tests for now.
adalinesimonian
added
pr: dependencies
TODO: Restore once postcss-html and postcss-markdown are PostCSS 8 compatible. re: #254 (comment)
|
Slight tangent: I've opened an issue on the Stylelint repo (stylelint/stylelint#5580, tracked here in #256) for type definitions issues upstream that I encountered while working on v1. In the meantime, I am using workarounds in this repository. Update: Potential fix up in stylelint/stylelint#5582 |
adalinesimonian
added
For Milestone Issue
and removed
pr: dependencies
Closes #233
validateandsnippetoptions set to['css', 'postcss']syntaxoptionconfigOverridesoption