fix: don't register document formatter twice #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Oct 4, 2021
ntwb
approved these changes
Oct 4, 2021
rchl
suggested changes
Oct 4, 2021
Allows language server formatting support to be used outside of VS Code
rchl
approved these changes
Oct 4, 2021
adalinesimonian
added
For Uncommitted Issue
and removed
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250, Closes #241
Fixes a bug where the extension is registered twice as a document formatter. One instance is a result of the server's
connection.onInitializeresponse, the other is the extension's own logic for registering a formatter per language ID. This PR replaces the extension's formatter registration implementation with server-side dynamic or static registration, depending on client capabilities.See #250 (comment)