Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shorthand-property-no-redundant-values false negatives for functions #7657

Merged
merged 7 commits into from Apr 27, 2024

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Apr 26, 2024

Which issue, if any, is this issue related to?

Ref #7656

Is there anything in the PR that needs further explanation?

I think supporting all functions makes sense, including var() or calc() etc.
-> Dropped var() support. See #7656 (comment)

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: b290aee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Mouvedia Mouvedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/rules/shorthand-property-no-redundant-values/index.mjs Outdated Show resolved Hide resolved
@ybiquitous ybiquitous merged commit f87f784 into main Apr 27, 2024
17 checks passed
@ybiquitous ybiquitous deleted the issue-7656 branch April 27, 2024 23:08
emmacharp pushed a commit to emmacharp/stylelint that referenced this pull request May 7, 2024
…tions (stylelint#7657)

Co-authored-by: Marc G. <Mouvedia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants