Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system test for CommonJS #7303

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add system test for CommonJS #7303

merged 2 commits into from
Nov 6, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #5291

Is there anything in the PR that needs further explanation?

This change also reverts the coverage threshold settings.

@ybiquitous
Add system test for CommonJS
60cde8f 
This change also reverts the coverage threshold settings.
@changeset-bot changeset-bot

This comment was marked as resolved.

Sign in to view
@ybiquitous ybiquitous linked an issue Nov 6, 2023 that may be closed by this pull request
Move to ESM #5291
Closed
@ybiquitous ybiquitous marked this pull request as ready for review November 6, 2023 13:21
jeddy3
jeddy3 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@ybiquitous ybiquitous merged commit 2649cc8 into v16 Nov 6, 2023
11 checks passed
@ybiquitous ybiquitous deleted the add-system-test-for-commonjs branch November 6, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to ESM
2 participants
@ybiquitous @jeddy3