Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ESM rules #7280

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Test ESM rules #7280

merged 5 commits into from
Nov 6, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Oct 25, 2023

Which issue, if any, is this issue related to?

Ref #5291
Follow-up to #7279

Is there anything in the PR that needs further explanation?

Note that this change uses the unpublished version of jest-preset-stylelint:
stylelint/jest-preset-stylelint#81
New version is published: https://github.com/stylelint/jest-preset-stylelint/releases/tag/6.3.2

This change should increase test coverage.

@changeset-bot

This comment was marked as resolved.

@Mouvedia
Copy link
Member

Mouvedia commented Oct 25, 2023

minor

We need to fix output uses in the tests.

@ybiquitous
Copy link
Member Author

We need to fix output uses in the tests.

It's out of the scope of this PR. I'll open another PR for that.

@ybiquitous

This comment was marked as resolved.

@ybiquitous

This comment was marked as resolved.

@ybiquitous ybiquitous mentioned this pull request Oct 30, 2023
Base automatically changed from remove-import-lazy to v16 November 6, 2023 07:15
Note that this change uses the unpublished version of `jest-preset-stylelint`:
stylelint/jest-preset-stylelint#81
@ybiquitous ybiquitous marked this pull request as ready for review November 6, 2023 08:40
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ybiquitous ybiquitous merged commit e252ecf into v16 Nov 6, 2023
14 checks passed
@ybiquitous ybiquitous deleted the test-esm-rules branch November 6, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants