Refactor plugin fixtures to CJS #7270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we support plugins only for CJS. So, this change explicitly appends the `.cjs` extension.
This comment was marked as resolved.
This comment was marked as resolved.
ybiquitous
commented
Oct 20, 2023
mattxwang
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Overall, this LGTM.
One question (that can be addressed later), you said:
Currently, we support plugins only for CJS. So, this change explicitly appends the
.cjsextension.
Should we document this somewhere (e.g. in Writing plugins or in the migration guide? I know this is "implicit" with the current state of Stylelint. but may be good to call out. I know it's not directly related to this PR (since it's only on test fixtures), but was just wondering.
|
I don't think adding that to the migration guide is needed, but adding that to the existing document may be good. But I believe it's best to support ESM plugins, not only adding it to the doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5291
Currently, we support plugins only for CJS. So, this change explicitly appends the
.cjsextension.