Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fixtures/broken-syntax/stylelint.config.js to CJS #7265

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Oct 19, 2023

Which issue, if any, is this issue related to?

Ref #5291

Is there anything in the PR that needs further explanation?

If migrating to ESM, CI would fail due to SIGSEGV errors. For example:
https://github.com/stylelint/stylelint/actions/runs/6578275243/job/17871645000?pr=7265#step:8:890

@changeset-bot

This comment was marked as resolved.

@ybiquitous ybiquitous marked this pull request as draft October 19, 2023 17:45
@ybiquitous ybiquitous changed the title Migrate fixtures/broken-syntax/stylelint.config.js to ESM Refactor fixtures/broken-syntax/stylelint.config.js to CJS Oct 19, 2023
@ybiquitous ybiquitous marked this pull request as ready for review October 19, 2023 17:52
@ybiquitous
Copy link
Member Author

Just rename. I'll merge this to proceed with the migration to ESM.

@ybiquitous ybiquitous merged commit f650ed5 into v16 Oct 20, 2023
14 checks passed
@ybiquitous ybiquitous deleted the esm-fixture-broken-syntax branch October 20, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant