Add --rule flag, --rules flag, --merge-rules flag and mergeRules option
#7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61e9858 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Mouvedia
force-pushed
the
mouvedia-rule
branch
from
892760b
to
a624ce2
Compare
Mouvedia
force-pushed
the
mouvedia-rule
branch
from
ade7316
to
61e9858
Compare
Mouvedia
changed the title
--rule flag, --merge-rules flag and mergeRules option
|
@Mouvedia Can you please wait until the |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Mouvedia
requested review from
romainmenke and
mattxwang
and removed request for
ybiquitous
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@Mouvedia You can restart this. But I'm concerned about where the |
Mouvedia
changed the title
--rule flag, --merge-rules flag and mergeRules option--rule flag, --rules flag, --merge-rules flag and mergeRules option
|
Closed in favour of #7418. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4331
levn has limited uses; I could refactor and use
JSON.parseinstead.e.g. having a schema for an object requires explicit property names
missing features
Passing a rule without its value seemed confusing.
What should
--rule color-no-invalid-hexdo exactly?Probably fetch the corresponding rule option in the config and, if found, discard all other rules.
I chose not to add this feature, for now; it needs to be discussed in a separate issue.
--rulesshould accept a file path (JSON)