-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function-no-unknown
light-dark
false positive
#7231
Conversation
🦋 Changeset detectedLatest commit: efab507 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
css-functions-list has released a new version
Oh, good eye! Should I make a PR updating the dep here, or update the dep itself (and treat this "bugfix" as a side effect)? Not sure how this normally works re: dep updates. Also, |
@mattxwang there's a bot that adds dependencies. Is there a way to trigger it? |
Ya, we can manually trigger Dependabot, or update PRs will come weekly on Monday. |
Gotcha. I think I meant more, how do we want this to be reflected in the changeset/changelog: is the dep update accompanied by fixing this false positive? i.e. am I adding the changeset to the PR? (also, I'll add the test case to the dependabot PR) |
Fixed: `function-no-unknown` false positives for `light-dark`, `linear` and `xywh`
Yup. |
Closes #7226.
No, it's self-explanatory.