Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function-no-unknown light-dark false positive #7231

Closed
wants to merge 1 commit into from

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Closes #7226.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: efab507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mouvedia
Mouvedia previously approved these changes Oct 13, 2023
@Mouvedia Mouvedia added the pr: blocked is blocked by another issue or pr label Oct 15, 2023
Copy link
Member

@Mouvedia Mouvedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mouvedia Mouvedia dismissed their stale review October 15, 2023 13:33

css-functions-list has released a new version

@mattxwang
Copy link
Member Author

Oh, good eye!

Should I make a PR updating the dep here, or update the dep itself (and treat this "bugfix" as a side effect)? Not sure how this normally works re: dep updates.

Also, webkit-gradient has also been added.

@Mouvedia
Copy link
Member

@mattxwang there's a bot that adds dependencies. Is there a way to trigger it?
The way to do it is to add a commit to that automatically created PR.

@Mouvedia Mouvedia closed this Oct 16, 2023
@ybiquitous
Copy link
Member

Ya, we can manually trigger Dependabot, or update PRs will come weekly on Monday.

@mattxwang
Copy link
Member Author

mattxwang commented Oct 16, 2023

Gotcha. I think I meant more, how do we want this to be reflected in the changeset/changelog: is the dep update accompanied by fixing this false positive? i.e. am I adding the changeset to the PR?

(also, I'll add the test case to the dependabot PR)

@Mouvedia
Copy link
Member

Mouvedia commented Oct 16, 2023

@mattxwang

Fixed: `function-no-unknown` false positives for `light-dark`, `linear` and `xywh`

am I adding the changeset to the PR?

Yup.

mattxwang added a commit that referenced this pull request Oct 17, 2023
@jeddy3 jeddy3 deleted the function-no-unknown-light-dark-fp branch November 5, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: blocked is blocked by another issue or pr
Development

Successfully merging this pull request may close these issues.

function-no-unknown: fix linear xywh light-dark false positives
3 participants