Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate alpha-value-notation rule to ESM #7182

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Migrate alpha-value-notation rule to ESM #7182

merged 1 commit into from
Oct 3, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref #5291

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot

This comment was marked as resolved.

Sign in to view
@ybiquitous ybiquitous marked this pull request as ready for review September 11, 2023 12:26
mattxwang
mattxwang approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Didn't realize you were waiting on a review, sorry.

This looks good to me! Thanks 😊

@ybiquitous
Copy link
Member Author

Never mind, thanks for the review!

By the way, the coverage degradation is due to jest-preset-stylelint uses require instead of import. We need to change the behavior after we finish to rewrite all rules in ESM.
https://github.com/stylelint/jest-preset-stylelint/blob/6.2.0/getTestRule.js#L18

@ybiquitous ybiquitous merged commit a5862c1 into v16 Oct 3, 2023
13 of 14 checks passed
@ybiquitous ybiquitous deleted the esm-alpha-value-notation branch October 3, 2023 00:31
@ybiquitous ybiquitous mentioned this pull request Oct 3, 2023
Closed
ybiquitous added a commit that referenced this pull request Oct 19, 2023
@ybiquitous
Migrate alpha-value-notation rule to ESM (#7182)
5f1764a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @mattxwang