-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to remove redundant calls to isStandardSyntaxMediaFeatureName
utility
#7021
Refactor to remove redundant calls to isStandardSyntaxMediaFeatureName
utility
#7021
Conversation
|
Can we wait for elirasza/stylelint-stylistic to be refactored first? If not we will have to remove our recommendations for the plugins in the documentation. |
I didn't know the functions from I will restore these files. |
isStandardSyntaxMediaFeature
utilitiesisStandardSyntaxMediaFeature
utilities
@romainmenke it's complicated: #6866 |
isStandardSyntaxMediaFeature
utilitiesisStandardSyntaxMediaFeatureName
utility
To be honest, I'm not in favor of leaving unused and internal modules (see also #6866 (comment)). As a maintainer, I feel it isn't easy to care about internal modules used by plugins. 😓 However, only this time, we've removed many utilities toward v16 (see #7002), so we can delay removing unused modules. I think it's acceptable to remove Could you open a new PR to remove it for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, the series of refactoring work for #6848 is great! 👏🏼
Thank you so much for your effort! @romainmenke
isStandardSyntaxMediaFeatureName
utilityisStandardSyntaxMediaFeatureName
utility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Two minor requests, otherwise LGTM.
Anyway, the series of refactoring work for #6848 is great! 👏🏼
Totally agree!
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thank you again for the reviews on all this 🙇 |
Closes #6848
These utilities aren't needed anymore.
@csstools/media-query-list-parser
only parses standard CSS as media feature AST nodes.I think #6848 can be closed as completed after this change.