Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused modules (from deprecated rules) #7003

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Remove unused modules (from deprecated rules) #7003

merged 1 commit into from
Jun 30, 2023

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Ref: #6979 (comment)

Is there anything in the PR that needs further explanation?

No changeset since it's not user-facing.

Re-running the script indicates no newly-unused files:

$ node scripts/find-unused-modules.mjs

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023

⚠️ No Changeset found

Latest commit: 08ec45b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Mouvedia
Copy link
Member

related: import-js/eslint-plugin-import#1469

@Mouvedia
Copy link
Member

I found flow type stubs that contain the utils being removed in the wild but since #6866 has no resolution yet, we can safely remove them.

ybiquitous
ybiquitous approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

@mattxwang mattxwang merged commit 5c7419d into v16 Jun 30, 2023
16 checks passed
@mattxwang mattxwang deleted the remove-unused-modules branch June 30, 2023 04:24
ybiquitous pushed a commit that referenced this pull request Jun 30, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
21dfacb 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 1, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
9db98c7 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 3, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
20716a3 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 3, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
c34c1c6 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
mattxwang added a commit that referenced this pull request Jul 4, 2023
@mattxwang
Remove unused modules (from deprecated rules) (#7003)
50cd1a1 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
mattxwang added a commit that referenced this pull request Jul 4, 2023
@mattxwang
Remove unused modules (from deprecated rules) (#7003)
6892022 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
@Mouvedia Mouvedia mentioned this pull request Jul 4, 2023
Closed
ybiquitous pushed a commit that referenced this pull request Jul 6, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
2806bd3 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 8, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
4ea781a 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 8, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
6ea6b18 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 13, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
3412f84 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 20, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
7cee2a4 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 24, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
eae137b 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 25, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
46e9b5f 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 26, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
1a3fef5 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 26, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
d208354 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Jul 27, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
dc73aca 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Aug 12, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
6abfd32 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Aug 14, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
6d7da60 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Aug 27, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
cc43f0c 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Aug 27, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
12619dc 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Sep 28, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
8dc915f 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
ybiquitous pushed a commit that referenced this pull request Oct 19, 2023
@mattxwang @ybiquitous
Remove unused modules (from deprecated rules) (#7003)
2129a51 
Ref: #6979 (comment)

Re-running the script indicates no newly-unused files:

```sh
$ node scripts/find-unused-modules.mjs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattxwang @Mouvedia @ybiquitous