Change more suitable examples in unit-no-unknown doc
#6854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unit-no-unknown` rule handles the `image-set()` function and the `x` unit. So, specifying `image-set` to the `ignoreFunctions` option doesn't make sense. Additionally, this change removes duplication in the test for `unit-no-unknown`. See also the demo: https://stylelint.io/demo/#N4Igxg9gJgpiBcICGACYAdAdilAjJYA1gOYBOEArplALQCWAtksTPCo8zDQM4wAuACiw4cAcgD0HFt3HcIDLlK4BGAB4A6AFYAHYqJRqANMJESlMuQvpMWNAEwadelA+PZTkmzAvzFXmgDMjrr6QSYAlADcWAC+IIYgAGZ0ADYwAHJICgggMKpZ2mnqYNzc8eAQmMnEORju6CCkFGncDWx1IigNVHR8NJgQNFSEAwDumG0ofE0wJjGx5ZBVdMQAYhCkTHw5mnKY5bDaZYgdXSDcfACeaSl0mHyTDSlIfN4P8SYNF9cwt-c0S2qPD4SGoSFIUEeIGerwuDQWMSAA
|
|
@romainmenke This is a friendly ping. Merging this PR before your refactoring work might be better to avoid extra conflicts. |
romainmenke
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6721 (I found this PR's problem during the issue discussion)
The
unit-no-unknownrule handles theimage-set()function and thexunit.So, specifying
image-setto theignoreFunctionsoption doesn't make sense.Additionally, this change removes duplicate cases in the test for
unit-no-unknown.See also the demo.