Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.js 14 support #6785

Conversation

MohitMaheshwari1711
Copy link

Which issue, if any, is this issue related to?

Closes #6740

Is there anything in the PR that needs further explanation?

The issue mentioned that the minimum version required should be v16.0.0; as per my observations, some packages, such as jest and others need version ^16.14.0. I have attached a screenshot for further clarification. Hence I have added support for v16.14.0 rather than 16.0.0.

Screenshot 2023-04-16 at 7 59 24 PM

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2023

⚠️ No Changeset found

Latest commit: 60ed1a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ybiquitous
Copy link
Member

@MohitMaheshwari1711 Thanks for the pull request. But I think this PR is too much for the reason I commented on #6740 (comment).

@ybiquitous ybiquitous added pr: blocked is blocked by another issue or pr and removed pr: blocked is blocked by another issue or pr labels Apr 20, 2023
@Mouvedia
Copy link
Member

I think if it has to be changed it should based on the LTS.
i.e. >=16.13.0"

@jeddy3 jeddy3 changed the title updated node version support from 14.13.0 to 16.14.0 Remove Node.js 14 support Jun 23, 2023
@@ -201,6 +201,6 @@
"typescript": "^5.0.4"
},
"engines": {
"node": "^14.13.1 || >=16.0.0"
"node": "^16.14.0 || >=18.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggest] I agree with @Mouvedia's suggestion on #6785 (comment). Node.js 16.13.0 is the first version of Node.js 16.x LTS series.

See https://nodejs.org/en/blog/release/v16.13.0

Suggested change
"node": "^16.14.0 || >=18.0.0"
"node": "^16.13.0 || >=18.0.0"

The ls-engines check passes:

$ npx ls-engines@latest
`node_modules` found; loading tree from disk...
┌────────┬─────────────────────────────────────────────────────────────────┐
│ engine │ Currently available latest release of each valid major version: │
├────────┼─────────────────────────────────────────────────────────────────┤
│ node   │ v20.3.1, v19.9.0, v18.16.1, v17.9.1, v16.20.1                   │
└────────┴─────────────────────────────────────────────────────────────────┘

┌───────────────────────────────────┬───────────────────────────┐
│ package engines:                  │ dependency graph engines: │
├───────────────────────────────────┼───────────────────────────┤
│ "engines": {                      │ "engines": {              │
│   "node": "^16.13.0 || >= 18.0.0" │   "node": ">= 16.13"      │
│ }                                 │ }                         │
└───────────────────────────────────┴───────────────────────────┘


Your “engines” field allows fewer node versions than your dependency graph does.
...

Surely, dev dependencies require higher Node.js versions. But we can ignore them because they're just for dev, and we should respect engines.node to support more users.

$ npx ls-engines@latest --dev
...
Your “engines” field does not exactly match your dependency graph‘s requirements!
...

@ybiquitous ybiquitous changed the base branch from main to v16 June 27, 2023 12:51
@ybiquitous
Copy link
Member

I've changed the base branch from main to v16. See #6930.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitMaheshwari1711 Could you consider addressing my review, please?

@ybiquitous
Copy link
Member

See #7020

@ybiquitous ybiquitous closed this Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove Node.js 14 support
3 participants