Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erroneous example from unit-no-unknown doc #6722

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

None, as it's a documentation fix.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

⚠️ No Changeset found

Latest commit: 7ec27d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ybiquitous ybiquitous marked this pull request as ready for review March 20, 2023 14:24
@Mouvedia
Copy link
Member

for the commit message

replace useless by erroneous

@ybiquitous ybiquitous changed the title Remove useless example from unit-no-unknown doc Remove erroneous example from unit-no-unknown doc Mar 21, 2023
@ybiquitous
Copy link
Member Author

@Mouvedia Thanks. I've changed the PR title and will change the commit message when squash and merge.

Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, LGTM!

(I'll let you merge)

@ybiquitous ybiquitous merged commit 80a49a3 into main Mar 29, 2023
@ybiquitous ybiquitous deleted the fix-unit-no-unknown-doc branch March 29, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants