Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected output in Node.js API lint result when any rule contains disableFix: true #6543

Merged
merged 3 commits into from Dec 28, 2022
Merged

Fix unexpected output in Node.js API lint result when any rule contains disableFix: true #6543

merged 3 commits into from Dec 28, 2022

Commits on Dec 23, 2022

  1. Fix Unexpected Node API output when any rule contains `disableFix: tr… 

    …ue` stylelint#6542

fixes stylelint#6542 and bv that should also fix stylelint/vscode-stylelint#369

Issue: The API did not return the fixed css in `output` if any rule contained `ruleDisableFix`.

I have removed the `ruleDisableFix` code, because it did not affect the code fixing itself and was assumingly wrongly used to change the content format of `output`.
I have adjusted some tests to adapt to the changed behaviour and extended the test conditions to check that the returned code has the correct fixes applied.

Issue was introduced in stylelint#5460
    @adrianjost
    adrianjost committed Dec 23, 2022
    Copy the full SHA
    8f972da View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Add changelog entry

    @ybiquitous
    ybiquitous committed Dec 28, 2022
    Copy the full SHA
    fe6b8db View commit details
    Browse the repository at this point in the history

  2. Apply code review suggestions

    @adrianjost
    adrianjost committed Dec 28, 2022
    Copy the full SHA
    b670fe4 View commit details
    Browse the repository at this point in the history