Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS compilation error due to needless file-entry-cache import #6393

Merged
merged 3 commits into from Oct 5, 2022
Merged

Fix TS compilation error due to needless file-entry-cache import #6393

merged 3 commits into from Oct 5, 2022

Commits on Oct 4, 2022

  1. fix(types): remove unused type import

    This type import was added in #6356, but during code review that PR was refactored to obviate the `file-entry-cache` types in the public API. The import was never removed. Keeping the import here results in [compilation errors](https://app.circleci.com/pipelines/github/palantir/blueprint/3156/workflows/9eda97ec-3a2f-4aa6-aa6c-89d5b65b8491/jobs/61694) for downstream consumers:
    
    ```
    ../../node_modules/stylelint/types/stylelint/index.d.ts:5:39 - error TS7016: Could not find a declaration file for module 'file-entry-cache'. '/home/circleci/project/node_modules/file-entry-cache/cache.js' implicitly has an 'any' type.
      Try `npm i --save-dev @types/file-entry-cache` if it exists or add a new declaration (.d.ts) file containing `declare module 'file-entry-cache';`
    
    5  import type * as fileEntryCache from 'file-entry-cache'
    ```
    
    @jeddy3 @kimulaco
    adidahiya committed Oct 4, 2022
    Copy the full SHA
    aa037f6 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e222ff1 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Update .changeset/fix-unused-type-import.md

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    adidahiya and ybiquitous committed Oct 5, 2022
    Copy the full SHA
    24ffdd9 View commit details
    Browse the repository at this point in the history